Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rework command structure #215

Merged
merged 4 commits into from
Jul 2, 2024
Merged

feat: rework command structure #215

merged 4 commits into from
Jul 2, 2024

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Jul 1, 2024

Overview

  • Reworks the sync command, to follow the pattern usually used among cobra-cli applications.

Fixes #202

@csatib02 csatib02 added area/build kind/enhancement Categorizes issue or PR as related to an improvement. labels Jul 1, 2024
@csatib02 csatib02 requested a review from ramizpolic July 1, 2024 14:57
@csatib02 csatib02 self-assigned this Jul 1, 2024
@csatib02 csatib02 requested a review from a team as a code owner July 1, 2024 14:57
@github-actions github-actions bot added the size/L Denotes a PR that changes 500-999 lines label Jul 1, 2024
@csatib02 csatib02 removed the request for review from a team July 1, 2024 15:10
ramizpolic
ramizpolic reviewed Jul 1, 2024
View reviewed changes
pkg/utils/logger.go Outdated Show resolved Hide resolved
pkg/apis/v1alpha1/syncjob_types.go Outdated Show resolved Hide resolved
cmd/sync.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/M Denotes a PR that changes 100-499 lines and removed size/L Denotes a PR that changes 500-999 lines labels Jul 2, 2024
@csatib02
feat: rework command structure
046d128 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02
chore: adjust build path
9256a62 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02
chore: code-review
ffd17f5 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02
feat: use struct for params
6fbaa6b 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02 csatib02 merged commit ab57ef0 into main Jul 2, 2024
15 checks passed
@csatib02 csatib02 deleted the feat/rework-sync-command branch July 2, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramizpolic ramizpolic ramizpolic approved these changes

Assignees

@csatib02 csatib02

Labels
area/build kind/enhancement Categorizes issue or PR as related to an improvement. size/M Denotes a PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite sync command to work with only the context created on command execution
2 participants
@csatib02 @ramizpolic