Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: AWS support secret mutation #131

Merged
merged 4 commits into from
Aug 8, 2024
Merged

feat: AWS support secret mutation #131

merged 4 commits into from
Aug 8, 2024

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Aug 2, 2024 •
edited
Loading

Overview

  • This PR starts implementing AWS support for the Webhook.
  • Follow-up PR's to be expected.
  • I wanted to break down this implementation per mutated kind, so it is easier to review.

Part of #62

Notes for reviewers

@csatib02 csatib02 added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 2, 2024
@csatib02 csatib02 self-assigned this Aug 2, 2024
@csatib02 csatib02 requested a review from a team as a code owner August 2, 2024 11:49
@csatib02 csatib02 changed the title Feat/aws support secrets feat: AWS support secrets Aug 2, 2024
@github-actions github-actions bot added the size/L Denotes a PR that changes 500-999 lines label Aug 2, 2024
@csatib02 csatib02 removed the request for review from a team August 2, 2024 11:49
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 2, 2024
View reviewed changes
@csatib02 csatib02 force-pushed the feat/aws-support-secrets branch 3 times, most recently from 2c94a3f to 26b24e8 Compare August 7, 2024 07:31
ramizpolic
ramizpolic previously approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csatib02 csatib02 requested a review from ramizpolic August 8, 2024 08:50
csatib02 added 4 commits August 8, 2024 11:06
@csatib02
chore: deps
c7bb432 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02
feat: aws support boilerplate
05b782d 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02
feat: aws support secrets
3f6ef39 
Signed-off-by: Bence Csati <bcsati@cisco.com>

feat: aws support secrets

Signed-off-by: Bence Csati <bcsati@cisco.com>

feat: aws support secrets

Signed-off-by: Bence Csati <bcsati@cisco.com>

feat: aws support secrets

Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02
feat: make k8s secret credential query params configurable
0685146 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02 csatib02 force-pushed the feat/aws-support-secrets branch from 905c0ed to 0685146 Compare August 8, 2024 09:07
akijakya
akijakya approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@akijakya akijakya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@csatib02 csatib02 merged commit e2516a0 into main Aug 8, 2024
26 checks passed
@csatib02 csatib02 deleted the feat/aws-support-secrets branch August 8, 2024 10:44
@csatib02 csatib02 mentioned this pull request Aug 8, 2024
Merged
@csatib02 csatib02 changed the title feat: AWS support secrets feat: AWS support secret mutation Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akijakya akijakya akijakya approved these changes

@sagikazarmark sagikazarmark Awaiting requested review from sagikazarmark

@ramizpolic ramizpolic Awaiting requested review from ramizpolic

Assignees

@csatib02 csatib02

Labels
area/provider/aws kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 500-999 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csatib02 @ramizpolic @akijakya