Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use verified publisher image hashicorp/vault #117

Merged

Conversation

tanmay-pnaik
Copy link
Contributor

@tanmay-pnaik tanmay-pnaik commented Jul 19, 2023

Overview

Fixes #116

Hashicorp has deprecated Duplicative Docker Images (see https://developer.hashicorp.com/vault/docs/v1.13.x/deprecation).
New versions of vault are only published to https://hub.docker.com/hashicorp/vault.
https://hub.docker.com/_/vault only contains old versions up to 1.13.3.

Also updated default Vault image version

Signed-off-by: Tanmay Pereira Naik <tanmay.naik@thoughtworks.com>
@tanmay-pnaik tanmay-pnaik changed the title chore: Use verified publisher image hashicorp/vault chore: Use verified publisher image hashicorp/vault Jul 19, 2023
Signed-off-by: Tanmay Pereira Naik <tanmay.naik@thoughtworks.com>
@tanmay-pnaik tanmay-pnaik force-pushed the chore/update-hashicorp-vault-image branch from 661ce1d to 0163dc8 Compare July 19, 2023 07:00
Copy link
Member

@akijakya akijakya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tanmay-pnaik! Please update the Makefile as well!

pkg/apis/vault/v1alpha1/vault_types.go Show resolved Hide resolved
Signed-off-by: Tanmay Pereira Naik <tanmay.naik@thoughtworks.com>
Signed-off-by: Tanmay Pereira Naik <tanmay.naik@thoughtworks.com>
@tanmay-pnaik
Copy link
Contributor Author

Thanks @tanmay-pnaik! Please update the Makefile as well!

Fixed.

Have left https://github.com/bank-vaults/vault-operator/blob/main/deploy/dev/microk8s/dev.yaml#L7 as is. Any suggestions on which tag we can use there?

pkg/apis/vault/v1alpha1/vault_types.go Outdated Show resolved Hide resolved
Signed-off-by: Tanmay Pereira Naik <tanmay.naik@thoughtworks.com>
@akijakya
Copy link
Member

Have left https://github.com/bank-vaults/vault-operator/blob/main/deploy/dev/microk8s/dev.yaml#L7 as is. Any suggestions on which tag we can use there?

It seems like it refers to a locally built image, I see no reason to not update it as well, but @sagikazarmark might have more experience whether it is some microk8s-related stuff or not.

@sagikazarmark
Copy link
Member

🤷

I don't see any reference to a custom built image, so I think it's safe to update it.

Signed-off-by: Tanmay Pereira Naik <tanmay.naik@thoughtworks.com>
@tanmay-pnaik
Copy link
Contributor Author

🤷

I don't see any reference to a custom built image, so I think it's safe to update it.

Updated in that file too.

Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sagikazarmark sagikazarmark merged commit fa1f2c0 into bank-vaults:main Jul 19, 2023
27 checks passed
@tanmay-pnaik tanmay-pnaik deleted the chore/update-hashicorp-vault-image branch July 19, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use hashicorp/vault image as _/vault is deprecated
3 participants