-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use verified publisher image hashicorp/vault
#117
chore: Use verified publisher image hashicorp/vault
#117
Conversation
Signed-off-by: Tanmay Pereira Naik <tanmay.naik@thoughtworks.com>
hashicorp/vault
Signed-off-by: Tanmay Pereira Naik <tanmay.naik@thoughtworks.com>
661ce1d
to
0163dc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tanmay-pnaik! Please update the Makefile as well!
Signed-off-by: Tanmay Pereira Naik <tanmay.naik@thoughtworks.com>
Signed-off-by: Tanmay Pereira Naik <tanmay.naik@thoughtworks.com>
Fixed. Have left https://github.com/bank-vaults/vault-operator/blob/main/deploy/dev/microk8s/dev.yaml#L7 as is. Any suggestions on which tag we can use there? |
Signed-off-by: Tanmay Pereira Naik <tanmay.naik@thoughtworks.com>
It seems like it refers to a locally built image, I see no reason to not update it as well, but @sagikazarmark might have more experience whether it is some microk8s-related stuff or not. |
🤷 I don't see any reference to a custom built image, so I think it's safe to update it. |
Signed-off-by: Tanmay Pereira Naik <tanmay.naik@thoughtworks.com>
Updated in that file too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Overview
Fixes #116
Hashicorp has deprecated Duplicative Docker Images (see https://developer.hashicorp.com/vault/docs/v1.13.x/deprecation).
New versions of vault are only published to https://hub.docker.com/hashicorp/vault.
https://hub.docker.com/_/vault only contains old versions up to 1.13.3.
Also updated default Vault image version