fix: Add mergo.WithAppendSlice for VaultConfigurerPodSpec #512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Hi team,
We want to be able to override some fields of the
bank-vaults
container in thevault-configurer
deployment. Currently, the operator does not allow merging of the 'containers' array into the predefined PodSpec.Fixes
I've added the mergo.WithAppendSlice argument this
mergo.Merge
function so you are able to override all the fields of the container.I used the following code snipped to test locally using mergo, it may come in handy for you to validate my suggested change: