Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable bao injector tests #423

Merged
merged 2 commits into from
Aug 21, 2024
Merged

chore: enable bao injector tests #423

merged 2 commits into from
Aug 21, 2024

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Aug 16, 2024 •
edited
Loading

Overview

  • Due to misconfigurations related to OpenBao still being dependent on Vault, using them together in a common job, makes them bump into each-other, thats why they are tested in separate jobs.

Fixes: #421

@csatib02
chore: enable bao injector tests
d5f5f23 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02 csatib02 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 16, 2024
@csatib02 csatib02 self-assigned this Aug 16, 2024
@csatib02 csatib02 requested a review from a team as a code owner August 16, 2024 10:56
@github-actions github-actions bot added the size/L Denotes a PR that changes 500-999 lines label Aug 16, 2024
@csatib02 csatib02 removed the request for review from a team August 16, 2024 11:18
@csatib02
feat: refactor tests into distinct jobs
0cc52bb 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02 csatib02 force-pushed the chore/enable-bao-injector-tests branch from 2a22254 to 0cc52bb Compare August 16, 2024 11:20
@csatib02 csatib02 merged commit 8220b9e into main Aug 21, 2024
14 checks passed
@csatib02 csatib02 deleted the chore/enable-bao-injector-tests branch August 21, 2024 14:55
@csatib02 csatib02 mentioned this pull request Aug 21, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akijakya akijakya akijakya approved these changes

@ramizpolic ramizpolic Awaiting requested review from ramizpolic

Assignees

@csatib02 csatib02

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 500-999 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable baoinjector tests
2 participants
@csatib02 @akijakya