Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix touches not work after first touch be canceled #265

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

marcuswu0814
Copy link
Contributor

Seems a wrong method call after this change: Golface@dff8da7

May fix this issue.

@marcuswu0814
Copy link
Contributor Author

marcuswu0814 commented Nov 5, 2020

Hi @bannzai , I think this is a high priority issue. Would you please help to review and release. 😀

@bannzai
Copy link
Owner

bannzai commented Nov 5, 2020

Hi, @marcuswu0814 Thanks for your great contributions! LGTM for your PR changes. But I will fix error about github actions at first. Ref: #266.

Could you rebase for this PR branch after I solved the github actions issue? I will mentioned you after solved the github actions problem. After that, I will confirm issue problem and do manually testing. So please wait for a while.

@bannzai
Copy link
Owner

bannzai commented Nov 6, 2020

@marcuswu0814 I solved github actions error. Could you rebase on master or merge master to this PR branch and push again? After push again, I guess to pass failure tests.

Seems a wrong method call after this change: dff8da7
@codecov-io
Copy link

Codecov Report

Merging #265 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #265   +/-   ##
=======================================
  Coverage   93.93%   93.93%           
=======================================
  Files           8        8           
  Lines         132      132           
=======================================
  Hits          124      124           
  Misses          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb72340...18d3b1e. Read the comment docs.

@marcuswu0814
Copy link
Contributor Author

Hi @bannzai, it seems work. 😀 Maybe this PR should be merge and release a new pod version ASAP. 😅

@bannzai
Copy link
Owner

bannzai commented Nov 9, 2020

Thank you ! I will merge and release soon!

@bannzai bannzai merged commit 1b7e074 into bannzai:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants