Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule servicemonitor template #1047

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Add rule servicemonitor template #1047

merged 1 commit into from
Mar 3, 2020

Conversation

boernd
Copy link
Contributor

@boernd boernd commented Feb 20, 2020

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
License Apache 2.0

What's in this PR?

Adds a servicemonitor template for the rule component.

Why?

The rule servicemonitor is configurable in values.yaml but the template is missing.

@tarokkk tarokkk self-requested a review February 20, 2020 12:16
@tarokkk tarokkk requested a review from ahma February 20, 2020 12:16
@kozmagabor kozmagabor requested review from kozmagabor and removed request for kozmagabor February 21, 2020 18:48
@tarokkk tarokkk added the thanos label Mar 3, 2020
ahma
ahma approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@ahma ahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @boernd LGTM

@tarokkk tarokkk merged commit 2fe993a into banzaicloud:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarokkk tarokkk tarokkk approved these changes

@ahma ahma ahma approved these changes

@kozmagabor kozmagabor Awaiting requested review from kozmagabor

Assignees
No one assigned
Labels
community enhancement thanos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boernd @tarokkk @ahma