[Cadence] Allow specifying annotations on services #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pregnor
approved these changes
Nov 4, 2021
|
@sagikazarmark @pregnor - Thanks for the approvals! I don't have |
|
Sure, I can do that later today, I am finishing up the manual pre-release tests. Would you prefer waiting for your other PR and release the 2 changes in a single version or should I release them separately as soon as merged? |
Lets do individual. I still need to make changes to the other one. Thank you! |
|
In that case please also don't forget to bump the patch version number in your second PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Allows passing in additional annotations to the services created by cadence
Checklist