Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update servicemonitor with right service labels #1314

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

ashwinrajadurai3
Copy link
Contributor

@ashwinrajadurai3 ashwinrajadurai3 commented Dec 13, 2021

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets nil
License Apache 2.0

What's in this PR?

Bug fix, service monitor label is not matching service label hence fixing it

Why?

Bug fix, service monitor label is not matching service label hence fixing it

Checklist

  • [x ] Related Helm chart(s) updated (if needed)

@ashwinrajadurai3
Copy link
Contributor Author

Please merge this PR @pepov @pregnor
This is in-reference to #1271 which has a minor correction causing implementation failure which i modified here.
Kindly do the needful

@ashwinrajadurai3
Copy link
Contributor Author

Thankyou @pregnor, can i please get another approval to merge this PR @pepov @ahma @tarokkk @mpritter76 @swirsky

@ahma ahma self-requested a review December 15, 2021 08:15
@ahma
Copy link
Contributor

ahma commented Dec 15, 2021

@ashwinrajadurai3 Thanks for the contribution, please bump the version as well.

@ashwinrajadurai3
Copy link
Contributor Author

@ashwinrajadurai3 Thanks for the contribution, please bump the version as well.

Bumped the version @ahma Please merge the PR now, Thanks!

@ashwinrajadurai3
Copy link
Contributor Author

@ashwinrajadurai3 Thanks for the contribution, please bump the version as well.

Bumped the version @ahma Please merge the PR now, Thanks!

Please do the needful here @ahma @pregnor

@pregnor pregnor merged commit 5aa78c8 into banzaicloud:master Jan 4, 2022
@pregnor
Copy link
Member

pregnor commented Jan 4, 2022

Merged and released a corresponding tag chart/spot-termination-exporter/0.0.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants