Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cadence] remove consistency default value #1325

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

5st7
Copy link
Contributor

@5st7 5st7 commented Aug 15, 2022

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets #1319
License Apache 2.0

What's in this PR?

Remove the consistency parameter because it is no longer a valid configuration parameter

Why?

Additional context

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

@5st7 5st7 changed the title remove consistency default value [Cadence]remove consistency default value Aug 15, 2022
@5st7 5st7 changed the title [Cadence]remove consistency default value [cadence] remove consistency default value Aug 15, 2022
@pregnor pregnor requested a review from akijakya August 15, 2022 10:39
Copy link
Contributor

@akijakya akijakya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pregnor
Copy link
Member

pregnor commented Aug 15, 2022

Thanks for the contribution, @akijakya will merge and release it soon.

@akijakya akijakya merged commit 5d51e7c into banzaicloud:master Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants