-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Cadence server 0.23.2 -> 0.24.0, web 3.29.5->3.32.0 #1327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to test it, aside from the question I posted LGTM.
489735a
to
00ace74
Compare
00ace74
to
030e75c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but manual test the rework pls.
I tested it with grpc and tchannel as well, everything seemed to work fine! |
@longquanzheng if you have time, I would appreciate your feedback on this! 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's in this PR?
Updated Cadence server 0.23.2 -> 0.24.0, web 3.29.5->3.32.0.
transport
config and defaultgrpc
to frontendWhy?
To support the latest Cadence server and web version.
Additional context
Tested with the regular chart update test.
Checklist