Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Cadence server 0.23.2 -> 0.24.0, web 3.29.5->3.32.0 #1327

Merged
merged 4 commits into from
Dec 1, 2022

Conversation

akijakya
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

Updated Cadence server 0.23.2 -> 0.24.0, web 3.29.5->3.32.0.

  • Switched system worker to gRPC as per this PR
  • Added transport config and default grpc to frontend

Why?

To support the latest Cadence server and web version.

Additional context

Tested with the regular chart update test.

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

Copy link
Member

@pregnor pregnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to test it, aside from the question I posted LGTM.

cadence/templates/server-configmap.yaml Outdated Show resolved Hide resolved
@akijakya akijakya force-pushed the release/cadence-server-0-24-0 branch from 489735a to 00ace74 Compare November 17, 2022 15:47
@akijakya akijakya force-pushed the release/cadence-server-0-24-0 branch from 00ace74 to 030e75c Compare November 17, 2022 16:01
Copy link
Member

@pregnor pregnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but manual test the rework pls.

@akijakya
Copy link
Contributor Author

LGTM, but manual test the rework pls.

I tested it with grpc and tchannel as well, everything seemed to work fine!

@akijakya
Copy link
Contributor Author

@longquanzheng if you have time, I would appreciate your feedback on this! 🙂

Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akijakya akijakya merged commit 76b8f20 into master Dec 1, 2022
@akijakya akijakya deleted the release/cadence-server-0-24-0 branch December 1, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants