cadence: allow existingSecret to be used in schema setup #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested, didn't experience any issues, however @mrd000 please also bump the chart patch version to |
akijakya
approved these changes
Dec 7, 2022
Done! I did not realise I'd need to do that, sorry. |
NP 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR makes cadence schema setup part of the helm chart work when a database password is only stored as a k8s secret via
existingSecretparameter and not supplied via thepasswordparameter. It currently works with schema setup/update being off. (schema/setup/enabled: falseandschema/update/enabled: false.Why?
This PR tries to fix the inconsistency of the chart behaviour. At the moment
existingSecretwould only work alone if the schema setup/update is not enabled. Once it's enabled there is an error reported by helm requiring the password being explicitly given to the chart as a value.Additional context
The change was tested on my test k8s setup.
Checklist