Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling k8s-csr for PKIbackend in kafka cluster spec #970

Merged
merged 12 commits into from
May 12, 2023

Conversation

shubhamcoc
Copy link
Contributor

@shubhamcoc shubhamcoc commented May 11, 2023

Description

This PR will enable to provide k8s-csr as PKIbackend in the Kafka cluster spec.

Type of Change

  • New Feature

Checklist

@shubhamcoc shubhamcoc requested a review from a team as a code owner May 11, 2023 13:09
Copy link
Contributor

@bartam1 bartam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pregnor pregnor merged commit 27bfa47 into banzaicloud:master May 12, 2023
bartam1 added a commit that referenced this pull request May 15, 2023
pregnor added a commit that referenced this pull request May 19, 2023
…#972)

This reverts commit 27bfa47.

Co-authored-by: Marton Barta <51166675+bartam1@users.noreply.github.com>
Co-authored-by: Darren Lau <panyuenlau@Gmail.com>
ctrlaltluc added a commit to adobe/koperator that referenced this pull request Jun 8, 2023
…herrypick-from-banzai-master

* banzai/master:
  Add new CruiseControlTaskOperation to represent Status Cruise Control Operation (banzaicloud#975)
  Use permanent Slack link in README (banzaicloud#985)
  update cert-manager dependency libraries to 1.11.2 (banzaicloud#981)
  Adding test cases for kafka user issuerRef group  (banzaicloud#967)
  fix(cc): re-creation of CC metrics topic (banzaicloud#976)
  Revert "Enabling k8s-csr for PKIbackend in kafka cluster spec (banzaicloud#970)" (banzaicloud#972)
  Using gomock to mock sigs.k8s.io/controller-runtime/pkg/client If (banzaicloud#973)

# Conflicts:
#	go.mod
#	go.sum
#	pkg/resources/kafka/kafka_test.go
panyuenlau added a commit that referenced this pull request Jun 8, 2023
…#972)

This reverts commit 27bfa47.

Co-authored-by: Marton Barta <51166675+bartam1@users.noreply.github.com>
Co-authored-by: Darren Lau <panyuenlau@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants