feat: add secret not created yet error response #3586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pregnor
approved these changes
Oct 21, 2021
In case of a PKE cluster on AWS during creation time.
akijakya
force-pushed
the
pke-secret-not-created-yet-response
branch
from
8c24299
to
4d3abac
Compare
pregnor
approved these changes
Oct 22, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of a PKE cluster on AWS during creation time.
What's in this PR?
The API now responds with a 409 status code getting a PKE cluster on AWS if there was an error getting the cluster secret during creation time.
Why?
For PKE (AWS) clusters the cluster creation immediately starts but the secret creation happens later and until the cluster secret is created, the cluster GET response was always going to run into error, resulting in a not too telling 500 Internal server error response a couple of times if the cluster creation was initiated from the banzai cli with the
-wflag.Checklist
[] OpenAPI and Postman files updated (if needed)[] User guide and development docs updated (if needed)[] Related Helm chart(s) updated (if needed)