Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EKS,Authn): fixed aws-iam-authn apiversion #3633

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

pregnor
Copy link
Member

@pregnor pregnor commented Aug 31, 2022

1.24 changed the APIVersion of the client.authentication.k8s.io.

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

Properly generating EKS KUBECONFIG client.authentication.k8s.io APIVersion for aws-iam-authenticator tokens.

Why?

Because it was not working well for UI/API downloaded KUBECONFIGs even though banzai CLI solves some of these problems.

Checklist

  • Implementation tested (with at least one cloud provider)
  • Code meets the Developer Guide
  • OpenAPI and Postman files updated (if needed)
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

@pregnor pregnor added kind/bug Something isn't working cloud/aws distribution/eks Amazon EKS labels Aug 31, 2022
@pregnor pregnor requested a review from akijakya August 31, 2022 11:54
@pregnor pregnor self-assigned this Aug 31, 2022
@pregnor pregnor marked this pull request as ready for review August 31, 2022 14:52
@pregnor pregnor changed the title fix(EKS,k8s1.24): fixed KUBECONFIG APIVersion gen @pregnor fix(EKS,Authn): fixed aws-iam-authn apiversion Aug 31, 2022
@pregnor pregnor changed the title @pregnor fix(EKS,Authn): fixed aws-iam-authn apiversion fix(EKS,Authn): fixed aws-iam-authn apiversion Aug 31, 2022
@pregnor pregnor merged commit 46419c1 into master Sep 1, 2022
@pregnor pregnor deleted the fix/k8s-1-24-kubeconfig branch September 1, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloud/aws distribution/eks Amazon EKS kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant