Fixed EKS new aws-iam-authn apiVersion #3635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pregnor
added
kind/bug
akijakya
approved these changes
Sep 1, 2022
|
Waiting for the proper time window with the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Properly generating EKS KUBECONFIG client.authentication.k8s.io APIVersion for aws-iam-authenticator tokens.
Why?
Because it was not working well for UI/API downloaded KUBECONFIGs even though banzai CLI solves some of these problems.
Checklist
OpenAPI and Postman files updated (if needed)User guide and development docs updated (if needed)Related Helm chart(s) updated (if needed)