Option to disable PKE on Azure and AWS #3637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akijakya
force-pushed
the
disable-pke-on-azure-option
branch
from
2172404
to
dba7472
Compare
pregnor
requested changes
Sep 8, 2022
akijakya
force-pushed
the
disable-pke-on-azure-option
branch
from
dba7472
to
0065ecc
Compare
pregnor
previously approved these changes
Sep 8, 2022
akijakya
force-pushed
the
disable-pke-on-azure-option
branch
from
0065ecc
to
e9d5de0
Compare
pregnor
previously approved these changes
Sep 8, 2022
pregnor
previously approved these changes
Sep 9, 2022
akijakya
force-pushed
the
disable-pke-on-azure-option
branch
from
f006210
to
a43c13b
Compare
pregnor
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Added config options to disable starting PKE clusters on Azure or AWS. If PKE is disabled on either of them, the cluster creation request now returns 400 Bad Request with the message
Not supported distribution type.Why?
It is nice to have more configuration options for Pipeline CP, also PKE on Azure is currently misbehaving, and we decided to drop support for now.
Additional context
Tested locally.
A similar solution is going to be implemented in Cloudinfo to remove the disabled options from the GUI as well.
Checklist
User guide and development docs updated (if needed)