Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GKE,1.24): fixed error msg match #3642

Merged
merged 1 commit into from
Sep 22, 2022
Merged

fix(GKE,1.24): fixed error msg match #3642

merged 1 commit into from
Sep 22, 2022

Conversation

pregnor
Copy link
Member

@pregnor pregnor commented Sep 22, 2022

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

Fixing error matching for GKE 1.24 create SA token case.

Why?

Because it is a generic K8s secret getter error and I matched a GKE error originally.

Checklist

  • Implementation tested (with at least one cloud provider)
  • Code meets the Developer Guide
  • [] OpenAPI and Postman files updated (if needed)
  • [] User guide and development docs updated (if needed)
  • [] Related Helm chart(s) updated (if needed)

@pregnor pregnor self-assigned this Sep 22, 2022
@pregnor pregnor merged commit 25fe49b into master Sep 22, 2022
@pregnor pregnor deleted the fix/gke-1-24-sa-token branch September 22, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants