Adjust hiding of require() calls for react-native #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code worked when the app was build in for debugging but failed when it was build for release. This makes sure the react-native packager ignores the require calls in both cases.
|
I tested it with both build modes and everything seems fine. Thanks for your patience! |
|
Nice, it's actually a cleaner hack than the first one too! Please submit this to af/envalid and I'll merge it :) |
|
I agree. This is a cleaner solution (especially with a comment 😉) |
|
Oups, I was actually trying to send this PR to af/envalid, but somehow got confused. |
|
This one should be correct: af#38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code worked when the app was build in for debugging but failed
when it was build for release. This makes sure the react-native packager
ignores the require calls in both cases.