Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bfcp: Add support for TCP transport for BFCP #411

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

Lastique
Copy link
Contributor

This includes both receiving inbound connections and initiating outgoing connections.

Note: This is somewhat different from our internal patch to support TCP for BFCP, so it is not fully tested. Our internal patch relies on other changes that were not included in this patch. Sending and receiving BFCP messages over TCP is tested.

@Lastique Lastique force-pushed the feature/tcp_bfcp_support branch 2 times, most recently from 147be55 to 25e9a90 Compare June 22, 2022 18:25
@sreimers
Copy link
Member

Can you extend the retest bfcp test code with some basic bfcp_listen and bfcp_connect test?

@Lastique Lastique force-pushed the feature/tcp_bfcp_support branch 2 times, most recently from 63f8097 to bf40a30 Compare June 23, 2022 14:50
@Lastique Lastique marked this pull request as draft June 23, 2022 15:09
@Lastique Lastique force-pushed the feature/tcp_bfcp_support branch from bf40a30 to 6806ccd Compare June 23, 2022 15:27
Lastique added a commit to Lastique/retest that referenced this pull request Jun 23, 2022
This test relies on and tests the updated BFCP APIs:

baresip/re#411
@Lastique
Copy link
Contributor Author

Added tests in baresip/retest#82.

@Lastique Lastique marked this pull request as ready for review June 23, 2022 16:47
Lastique added a commit to Lastique/retest that referenced this pull request Jun 23, 2022
This test relies on and tests the updated BFCP APIs:

baresip/re#411
This includes both receiving inbound connections and initiating
outgoing connections.
@Lastique Lastique force-pushed the feature/tcp_bfcp_support branch from 6806ccd to d7ab4a2 Compare June 25, 2022 14:13
Lastique added a commit to Lastique/retest that referenced this pull request Jun 25, 2022
This test relies on and tests the updated BFCP APIs:

baresip/re#411
Lastique added a commit to Lastique/retest that referenced this pull request Jun 25, 2022
This test relies on and tests the updated BFCP APIs:

baresip/re#411
Lastique added a commit to Lastique/retest that referenced this pull request Jun 25, 2022
This test relies on and tests the updated BFCP APIs:

baresip/re#411
@sreimers sreimers merged commit 83f2bc1 into baresip:main Jul 6, 2022
sreimers pushed a commit to baresip/retest that referenced this pull request Jul 6, 2022
This test relies on and tests the updated BFCP APIs:

baresip/re#411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants