compat: fix UberTraceContext extraction #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we were extracing the span context from an uber-trace-id header, we didn't properly handle the case of flags=0. It was expecting, for the flags, a hex encoded string, but in fact, the flags is just a base 16 integer field. The correct conversion is to just use ParseInt with base 16. The test cases are taken from topic manager examples using the jaeger client with go-opentracing.
wade-arista
force-pushed
the
wade.fixUberOtelExtract
branch
from
9d3ecc3
to
8f3c6c1
Compare
yabberyabber
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we were extracing the span context from an uber-trace-id header, we didn't properly handle the case of flags=0. It was expecting, for the flags, a hex encoded string, but in fact, the flags is just a base 16 integer field.
The correct conversion is to just use ParseInt with base 16.
The test cases are taken from topic manager examples using the jaeger client with go-opentracing.