Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to go v1.13.4 #281

Merged
merged 2 commits into from
Nov 4, 2019
Merged

Upgrade to go v1.13.4 #281

merged 2 commits into from
Nov 4, 2019

Conversation

chenrui333
Copy link
Contributor

Upgrade to go v1.13.3

Relates to Homebrew/homebrew-core#45962

@chenrui333
Copy link
Contributor Author

test-coverage step failed, https://github.com/chenrui333/cli53/runs/280876291

go: github.com/chenrui333/cli53/internal/features: github.com/chenrui333/cli53@v0.0.0-20191029072227-b7516ac135f9: parsing go.mod:
	module declares its path as: github.com/barnybug/cli53
	        but was required as: github.com/chenrui333/cli53
##[error]Makefile:30: recipe for target 'test-coverage' failed

barnybug
barnybug requested changes Nov 1, 2019
View reviewed changes
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@chenrui333 chenrui333 changed the title Upgrade to go v1.13.3 Upgrade to go v1.13.4 Nov 1, 2019
@chenrui333
Copy link
Contributor Author

@barnybug Updated the PR to use the latest golang version. Let me know if it works. Thanks!

@barnybug barnybug merged commit 3dc6a91 into barnybug:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barnybug barnybug barnybug requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenrui333 @barnybug