Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated OpenSSL links #127

Closed
wants to merge 1 commit into from
Closed

Updated OpenSSL links #127

wants to merge 1 commit into from

Conversation

laggingreflex
Copy link

Updated broken OpenSSL for Windows binary links
Add other sources for getting binaries

Updated broken OpenSSL for Windows binary links
Add other sources for getting binaries
@barrysteyn
Copy link
Owner

Why is this necessary? From version 6.0 onwards, there is no need for using OpenSSL.

@laggingreflex
Copy link
Author

Oh I didn't notice that. I was on a project with older version (5.4.1).
I'll upgrade to 6 then. So never mind I guess..

@mehcode
Copy link

mehcode commented Apr 29, 2016

@barrysteyn Then why is it still on the Readme? 😸

@barrysteyn
Copy link
Owner

@mehcode You are right, it shouldn't be there. I will remove the section...

@laggingreflex
Copy link
Author

For context, I inherited a project that used this as a dependency, and me being the only one of the devs on Windows, the error I was getting was something like this:

module.js:485
 process.dlopen(filename, module.exports);
 ^
 Error: The specified module could not be found.

which didn't make it immediately obvious that it was due to lack of OpenSSL on windows. I had to come across this to figure it all out. Only then I visited scrypt repo to find the same info which undeniably confirmed it.
For that reason I think we should leave a little bit of info about OpenSSL on Windows specially pertaining to users coming from/for v5. I know it does say "there is no need to use an external OpenSSL library anymore" but maybe making OpenSSL bold, or even reiterating that v5 used to use OpenSSL and you should either upgrade to v6 or something like that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants