Query params substitution

[JonoB]

It would be great if this could automatically substitute the params for each query into the query string

[barryvdh]

So select * fromuserswhereid= ? limit 1 would be select * fromuserswhereid= 4 limit 1? Would probably be nice, but should be in the php-debugbar project, because I use the default PdoDataCollector

[barryvdh]

Actually, there already is an option to substitue the parameters in a TracedStatement, I'll check why that isn't used.

[JonoB]

Looks like this has been enabled now php-debugbar/php-debugbar@f5cb5a1

Wasn't sure if you wanted to expose this config value in the laravel version, but something like this would probably work (untested):

if($this->collects('db', true) and isset($this->app['db'])){
    try{
        $pdo = new TraceablePDO( $this->app['db']->getPdo());
        $collector = new PDOCollector($pdo);
        $collector->setRenderSqlWithParams($this->app['config']->get('laravel-debugbar::config.render_sql_with_params', true));
        $debugbar->addCollector($collector);
    }catch(\PDOException $e){
        //Not connection set..
    }
}

[barryvdh]

Yeah I'll make a config for this.
Op 25 okt. 2013 11:13 schreef "JonoB" notifications@github.com:

Looks like this has been enabled now php-debugbar/php-debugbar@f5cb5a1php-debugbar/php-debugbar@f5cb5a1

Wasn't sure if you wanted to expose this config value in the laravel
version, but something like this would probably work (untested):

if($this->collects('db', true) and isset($this->app['db'])){
try{
$pdo = new TraceablePDO( $this->app['db']->getPdo());
$collector = new PDOCollector($pdo);
$collector->setRenderSqlWithParams($this->app['config']->get('laravel-debugbar::config.render_sql_with_params', true));
$debugbar->addCollector($collector);
}catch(\PDOException $e){
//Not connection set..
}}

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/21#issuecomment-27075916
.

[barryvdh]

Added a config for this, probably need to re-publish your config, but it's on by default.

[JonoB]

Awesome, thanks

[JonoB]

Hey Barry, just tried this out for the first time. Is there a reason that the params are surrounded with < and >?

select * from `users` where `id` = <26313> limit 1

I'm guessing that this is a phpdebugbar issue?

[barryvdh]

Yeah I said that here: php-debugbar/php-debugbar#38
That is the behaviour of the function that was already present.
Maybe you can submit a PR to change that to '123' instead of <123>

[barryvdh]

Default is now ', but it is an option in the latest version.

[JonoB]

Awesome :)