-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 7 Compatibility #497
Comments
We can't typehint the new Errors right? So no typehinting at all then? |
Hmm, is it possible to create a new branch for php7? For typehinting you can use Throwable interface. |
@iwex did you create an issue about this on |
@marktopper no :) |
So perhaps just like this; remove the typehint and Check at runtime. |
…th type-hint in php7 barryvdh#497
Works fine with: PHP 7.0.4 |
@tje3d |
@vjoao |
It should work in PHP 7.x when exceptions are thrown, but not when errors are thrown. |
It was a mistake on my side. Exceptions are namespaced and I forgot to use them. |
Hi! |
@alejandrozorita |
Can you try disabling collectors until it doesn't happen, so we can narrow down which one it is? |
@barryvdh Just tried this. It seems to be the Exceptions collector that is giving issues. |
Same problem with 7.0.9 . |
Same with PHP 7.0.5-2 on a default Laravel Homestead |
Same problem here...
|
Does the above commit fix it for you (Try |
Fixed! :) Thanks! |
I have such exception:
FatalThrowableError in ExceptionsCollector.php line 28: Type error: Argument 1 passed to DebugBar\DataCollector\ExceptionsCollector::addException() must be an instance of Exception, instance of ParseError given, called in /home/iwex/vagrant/chicago/vendor/maximebf/debugbar/src/DebugBar/DataCollector/ExceptionsCollector.php on line 32
The text was updated successfully, but these errors were encountered: