Add optional request header to disable debugbar response injection #547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional header that you can add to your request to disable the debugbar data collection/response injection. I looked through the code and could not find anything obvious to do this.
I experienced the initial issue with running the Node Laravel Echo Server. When joining a private channel, it sends an HTTP request to the broadcasting auth endpoints, which in turn replies "true" if the user can join the channel. However, in a development environment with response injection enabled, the debugbar injection happens and the echo server is unable to parse the reply (it's expecting JSON) correctly. Having a way to disable the injection with this request would remediate this issue.
I hope this is useful and if something is obviously wrong, any pointers would be great. This is my #1 pull request on an open source project!