Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic methods for DOMPDF instance #892

Merged
merged 1 commit into from
Jun 26, 2022
Merged

Conversation

erikn69
Copy link
Contributor

@erikn69 erikn69 commented Jun 14, 2022

is possible to provide access to all dompdf methods using __call magic method?
This PR avoid adding a method wrapper for each dompdf method

Those PRs will be avoid if this PR is posible

Also, after this, setPaper could be deleted

public function setPaper($paper, string $orientation = 'portrait'): self
{
$this->dompdf->setPaper($paper, $orientation);
return $this;
}


UPDATE: Test and phpDoc added

@erikn69 erikn69 force-pushed the magic_m branch 5 times, most recently from df7ce20 to b8b1d16 Compare June 14, 2022 17:57
@barryvdh barryvdh merged commit 76c4fdd into barryvdh:master Jun 26, 2022
@erikn69 erikn69 deleted the magic_m branch June 28, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants