Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What to do with url containing only the tld? #51

Closed
Yomguithereal opened this issue Jul 9, 2018 · 2 comments · Fixed by #61
Closed

What to do with url containing only the tld? #51

Yomguithereal opened this issue Jul 9, 2018 · 2 comments · Fixed by #61
Assignees
@barseghyanartur
Labels
question
Milestone
0.10

Comments

@Yomguithereal
Copy link
Contributor

@barseghyanartur I have a question: what should we do with urls such as:

http://cloud.fedoraproject.org

where the whole domain string is just a tld?

I know those cases are edge and probably illegal but they do work in browsers. Currently return values for those cases are not consistent (either a false or empty or return value).

I propose we return the the tld and blank the domain/subdomain etc.
@barseghyanartur barseghyanartur self-assigned this Jul 9, 2018
@barseghyanartur
Copy link
Owner

@Yomguithereal:

I agree. Let's just return the tld.

In case of an object domain/subdomain properties shall be blank. Perhaps the fld shall in this case be just equal to tld.

@barseghyanartur barseghyanartur added this to the 0.10 milestone Jul 9, 2018
@Yomguithereal
Copy link
Contributor Author

I'll draft a PR to support this when I can.

Yomguithereal added a commit to Yomguithereal/tld that referenced this issue Oct 28, 2019
@Yomguithereal
Handling urls that are only a TLD
ad965d6 
Examples:
  - https://cloud.fedoraproject.org
  - https://github.io

Fixes barseghyanartur#51
@Yomguithereal Yomguithereal mentioned this issue Oct 28, 2019
Merged
@Yomguithereal Yomguithereal mentioned this issue Oct 31, 2019
Closed
@barseghyanartur barseghyanartur mentioned this issue Jan 12, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barseghyanartur barseghyanartur

Labels
question
Projects
None yet
Milestone
0.10
Development

Successfully merging a pull request may close this issue.

Handling urls that are only a TLD Yomguithereal/tld
2 participants
@Yomguithereal @barseghyanartur