Skip to content

Commit

Permalink
fix(BREAKING): remove dead --prompt flag (denoland#22038)
Browse files Browse the repository at this point in the history
It appears the `--prompt` flag has done nothing for some time. Perhaps,
since denoland#13650. Classifying this as a dead functionality removal for this
reason.

Did this while working on denoland#22021.
  • Loading branch information
iuioiua authored and bartlomieju committed Jan 23, 2024
1 parent 96a2db0 commit 033219a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 10 deletions.
9 changes: 0 additions & 9 deletions cli/args/flags.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2728,15 +2728,6 @@ fn permission_args(app: Command) -> Command {
.action(ArgAction::SetTrue)
.help(ALLOW_ALL_HELP),
)
.arg(
Arg::new("prompt")
.long("prompt")
.action(ArgAction::SetTrue)
.hide(true)
.help(
"deprecated: Fallback to prompt if required permission wasn't passed",
),
)
.arg(
Arg::new("no-prompt")
.long("no-prompt")
Expand Down
2 changes: 1 addition & 1 deletion cli/tests/integration/run_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3060,7 +3060,7 @@ itest!(byte_order_mark {
fn issue9750() {
TestContext::default()
.new_command()
.args_vec(["run", "--prompt", "run/issue9750.js"])
.args_vec(["run", "run/issue9750.js"])
.with_pty(|mut console| {
console.expect("Enter 'yy':");
console.write_line_raw("yy");
Expand Down

0 comments on commit 033219a

Please sign in to comment.