230 test wallet was removed #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration query. Create test_wallet for local development and tests.
bartossh
requested review from
kubagruszka,
cezarykujawa,
kmroz,
dmatusiewicz-consult-red and
cezary-kujawa-red
Closed
kmroz
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point in the development process, I was wrongly thinking that test_wallet is not needed. But for tests on development, we need that wallet as there is a query running in the migration docker_postgres_init.sql that adds the wallet public address as the trusted so the validator using that wallet can connect to the system.
There is a need to get the wallet back and update the query.