Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid redundant git switch in Dockerfile for cleaner and more effic… #344

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Rufusfavour
Copy link

…ient git checkout

The original Dockerfile included a git switch command after cloning the repository, which was redundant since the commit hash could be checked out directly after the clone. This update removes the unnecessary git switch and performs the commit checkout directly with git checkout $COMMIT. This reduces the complexity of the build process and improves clarity.

Summary of Update:

  1. Removed the redundant git switch in the op-node build stage.
  2. Directly checked out the commit using git checkout $COMMIT after cloning.

…ient git checkout

The original Dockerfile included a git switch command after cloning the repository, which was redundant since the commit hash could be checked out directly after the clone. This update removes the unnecessary git switch and performs the commit checkout directly with git checkout $COMMIT. This reduces the complexity of the build process and improves clarity.

Summary of Update:

1. Removed the redundant git switch in the op-node build stage.
2. Directly checked out the commit using git checkout $COMMIT after cloning.
@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Remove -depth 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants