Prefix private constants with underscore #13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prefixes private constants with
_
.A few notes on the adopted style guide
We are most likely aligned with the Solidity style guide:
private
andinternal
symbols should be prefixed with an_
.private
symbols should also be prefixed with an_
.internal
symbols should NOT be prefixed with an_
. This is because we consider that the libraryinternal
symbols are part of its publicly exposed API. This seems to be a generally accepted convention, as libraryinternal
s are often used instead ofpublic
ones to avoid performing an expensive additionalDELEGATECALL
.