Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fault proof withdrawals for Base on Mainnet #23

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

awilliams1-cb
Copy link
Contributor

Queueing up change to enable fault proof withdrawals for Base on Mainnet. DisputeGameFactory address taken from https://github.com/base-org/web/blob/master/apps/base-docs/docs/building-with-base/base-contracts.md?plain=1#L79

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 29, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

disputeGameFactory: "0x0000000000000000000000000000000000000000",
faultProofs: false,
l2OOAddress: "0x0000000000000000000000000000000000000000",
disputeGameFactory: "0x43edB88C4B80fDD2AdFF2412A7BebF9dF42cB40e",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Confirmed.

@cb-heimdall
Copy link
Collaborator

Review Error for cbfyi @ 2024-10-29 18:00:34 UTC
User must have write permissions to review

@cbfyi
Copy link

cbfyi commented Oct 30, 2024

@mdehoog

@mdehoog mdehoog merged commit 254f325 into base:main Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants