Add configuration option for auditor method name attribute

[olivier-thatch]

Adds a new configuration option auditor_name_attr that accepts a Symbol containing the name of the attribute on the auditor class that returns the auditor's name to display in the UI.

Use case: our User record does not have a name field. We could define a name method on our User model class, but having to define a custom method on a class in our app for the sake of a third-party gem is a bit annoying. Instead, with this change, we can do:

config.audits1984.auditor_name_attr = :email

I've tested this change in our app and verified that it works as expected.

cc @jorgemanrubia

[jorgemanrubia]

Hi @olivier-thatch,

Thanks for the PR. While it brings flexibility, I find the proc to extract the name a bit off. What about an option to configure the auditor_name_attribute that defaults to current name. Instead of reading #name the could would do public_send(Audits1984.auditor_name_attribute)

[olivier-thatch]

@jorgemanrubia Updated the PR as requested. (Your suggestion was actually my first approach for this PR :) I thought some folks might appreciate the extra flexibility, but I agree it's probably not needed.)

[jorgemanrubia]

Thanks @olivier-thatch. Could you rename to auditor_name_attribute please? Very subjective, but I'm not a big fan of abbreviations when naming things 😅. I'll merge with that in place 🙏.

[olivier-thatch]

Done :)

[jorgemanrubia]

Thank you!

[olivier-thatch]

You're welcome!

No rush, but if you could release new versions of console1984 and audits1984 with the changes I submitted, it would be greatly appreciated too :)

[jorgemanrubia]

Hey I already did after merging the PRs! Latest versions should include the last changes.

[olivier-thatch]

🚀 Oops! Sorry I didn't check before asking 🤦 Thanks!