Check the connection before logging statements #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the database connection has been lost you can't reconnect because console1984 raises an error when it tries to record the statement. Let's check the connection first and reconnect if it is not active.
jorgemanrubia
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
Looks great @djmb.
Maybe we could add a wrapper helper silence_logging_and_ensure_connected that does both things to remove the dups? 🤔. In any case good call to place this logic here in the database logger 👍.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the database connection has been lost you can't reconnect because console1984 raises an error when it tries to record the statement.
Let's check the connection first and reconnect if it is not active.
cc @jorgemanrubia