Change colorize gem to rainbow, reason: License #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This is great, thank you so much @arturictus.
I think I used colorize in the very first internal version of console1984, but we ran into some performance problems when running some seeding scripts. I am not sure if it was colorize or other, I'll check. If performance is good, totally good with this change. Thank you so much!
arturictus
changed the title
|
I still need to validate performance in that scenario I mentioned. I will do that shortly. Thanks @arturictus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
colorize uses GLP-2
The GPL licenses include a strong copyleft clause, which could cause to the user to be required to publish the source code.