Pass OAuth 2 errors through to the app as flash[:google_sign_in_error] #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy
commented
Mar 6, 2019
| unauthorized_client | ||
| unsupported_grant_type | ||
| invalid_scope | ||
| ] |
There was a problem hiding this comment.
Could stash these away in e.g. lib/google_sign_in/errors.rb. Exposing so apps can also validate params[:error].presence_in(GoogleSignIn::OAUTH2_ERRORS)
| end | ||
|
|
||
| def error_message | ||
| params[:error].presence_in(GoogleSignIn::OAUTH2_ERRORS) || "invalid_request" | ||
| end |
There was a problem hiding this comment.
Fall back to the invalid_request catch-all.
georgeclaghorn
approved these changes
Mar 6, 2019
Rather than responding with 400 Bad Request due to missing `code` param.
* Allows app to treat this case as a failed sign-in * Generic `invalid_request` error in flash[:google_sign_in_error] rather returning 422 Unprocessable Entity directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than responding with 400 Bad Request due to missing
codeparam.Changes for apps to be aware of:
flash[:google_sign_in_error]set to one of the OAuth 2 Authorization Code Grant errors.stateparams are now passed to the app as errors so they can be treated as failed sign-ins.