Skip to content

Commit

Permalink
ci: use fail-fast: false instead of continue-on-error: true
Browse files Browse the repository at this point in the history
This will give us proper red/green signal on the test suite while
still running the entire matrix.
  • Loading branch information
flavorjones committed Jan 20, 2025
1 parent 5f04e42 commit 40c6d52
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
tests:
strategy:
matrix:
fail-fast: false
ruby-version:
- "3.1"
- "3.2"
Expand All @@ -37,7 +38,6 @@ jobs:
gemfile: gemfiles/rails_edge.gemfile
name: ${{ format('Tests (Ruby {0})', matrix.ruby-version) }}
runs-on: ubuntu-latest
continue-on-error: true
env:
BUNDLE_GEMFILE: ${{ github.workspace }}/${{ matrix.gemfile }}
steps:
Expand Down

0 comments on commit 40c6d52

Please sign in to comment.