feat: adding page watcher #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniel-Boll
approved these changes
Aug 7, 2024
| @@ -1,6 +1,6 @@ | |||
| import type { PlasmoCSConfig } from "plasmo"; | |||
|
|
|||
| import { appLoader } from "~scripting"; | |||
| import Kernel from "@Scripting/index"; | |||
There was a problem hiding this comment.
This is probably going to be reverted eventually, nobody in the ecosystem uses PascalCase on the path aliases.
There was a problem hiding this comment.
Also, the preferred way of exporting is not default in most of the cases. So we would have:
Suggested change
| import Kernel from "@Scripting/index"; | |
| import { Kernel } from "@scripting"; |
This is probably what we will be aiming at. But this can be changed later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
One of our goals is to provide a smooth integration with Twitch as a whole, but until now we only supported the actual refreshed browser tab and if you switch to another inside Twitch, the app stops working.
Changes
Closes #21