Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: env validation with zod #9

Merged
merged 2 commits into from
Aug 2, 2024
Merged

feat: env validation with zod #9

merged 2 commits into from
Aug 2, 2024

Conversation

henrique-leme
Copy link
Contributor

  • Remove ts-ignore and add the @types/node to respect the types and avoid future problems
  • Add Zod for better and furthue validations
  • Make a config file for the env to validate it

@henrique-leme henrique-leme changed the title Env validation with zod feat: env validation with zod Aug 2, 2024
DanielHe4rt
DanielHe4rt approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@DanielHe4rt DanielHe4rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DanielHe4rt DanielHe4rt linked an issue Aug 2, 2024 that may be closed by this pull request
feature: environment variables on extension #6
Closed
@DanielHe4rt DanielHe4rt merged commit 488e1d9 into basementdevs:feat/env-variables Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielHe4rt DanielHe4rt DanielHe4rt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: environment variables on extension
2 participants
@henrique-leme @DanielHe4rt