Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add namespace #47

Merged
merged 1 commit into from
May 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/apps/ingest.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ var IngestCmd = &cobra.Command{
}

func ingest(ps string) error {
f := friday.Fri.WithContext(context.TODO()).OriginFile(&ps)
f := friday.Fri.WithContext(context.TODO()).Namespace("test").OriginFile(&ps)
res := &friday.IngestState{}
f = f.Ingest(res)
if f.Error != nil {
Expand Down
5 changes: 5 additions & 0 deletions pkg/friday/friday.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,3 +116,8 @@ func (f *Friday) WithContext(ctx context.Context) *Friday {
}
return t
}

func (f *Friday) Namespace(namespace string) *Friday {
f.statement.context = context.WithValue(f.statement.context, "namespace", namespace)
return f
}
16 changes: 16 additions & 0 deletions pkg/vectorstore/postgres/migrate.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,22 @@ func buildMigrations() []*gormigrate.Migration {
return nil
},
},
{
ID: "2024051400",
Migrate: func(db *gorm.DB) error {
err := db.AutoMigrate(
&Index{},
)

if err != nil {
return err
}
// init namespace
_ = db.Exec(`UPDATE friday_idx SET namespace='global' WHERE 1=1;`)
return nil
},
Rollback: func(db *gorm.DB) error { return nil },
},
}
}

Expand Down
1 change: 1 addition & 0 deletions pkg/vectorstore/postgres/model.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import (
type Index struct {
ID string `gorm:"column:id;type:varchar(256);primaryKey"`
Name string `gorm:"column:name;index:index_name"`
Namespace string `gorm:"column:namespace;index:index_namespace"`
OID int64 `gorm:"column:oid;index:index_oid"`
Group int `gorm:"column:idx_group;index:index_group"`
ParentID int64 `gorm:"column:parent_entry_id;index:index_parent_id"`
Expand Down
24 changes: 20 additions & 4 deletions pkg/vectorstore/postgres/postgres.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ import (
"github.com/basenana/friday/pkg/vectorstore/db"
)

const defaultNamespace = "global"

type PostgresClient struct {
log logger.Logger
dEntity *db.Entity
Expand Down Expand Up @@ -72,6 +74,10 @@ func NewPostgresClient(log logger.Logger, postgresUrl string) (*PostgresClient,
}

func (p *PostgresClient) Store(ctx context.Context, element *models.Element, extra map[string]any) error {
namespace := ctx.Value("namespace")
if namespace == nil {
namespace = defaultNamespace
}
return p.dEntity.WithContext(ctx).Transaction(func(tx *gorm.DB) error {
if extra == nil {
extra = make(map[string]interface{})
Expand All @@ -91,9 +97,10 @@ func (p *PostgresClient) Store(ctx context.Context, element *models.Element, ext
}

v.Extra = string(b)
v.Namespace = namespace.(string)

vModel := &Index{}
res := tx.Where("name = ? AND idx_group = ?", element.Name, element.Group).First(vModel)
res := tx.Where("namespace = ? AND name = ? AND idx_group = ?", namespace, element.Name, element.Group).First(vModel)
if res.Error != nil && res.Error != gorm.ErrRecordNotFound {
return res.Error
}
Expand All @@ -109,7 +116,7 @@ func (p *PostgresClient) Store(ctx context.Context, element *models.Element, ext
}

vModel.Update(v)
res = tx.Where("name = ? AND idx_group = ?", element.Name, element.Group).Updates(vModel)
res = tx.Where("namespace = ? AND name = ? AND idx_group = ?", namespace, element.Name, element.Group).Updates(vModel)
if res.Error != nil || res.RowsAffected == 0 {
if res.RowsAffected == 0 {
return errors.New("operation conflict")
Expand All @@ -121,6 +128,10 @@ func (p *PostgresClient) Store(ctx context.Context, element *models.Element, ext
}

func (p *PostgresClient) Search(ctx context.Context, query models.DocQuery, vectors []float32, k int) ([]*models.Doc, error) {
namespace := ctx.Value("namespace")
if namespace == nil {
namespace = defaultNamespace
}
vectors64 := make([]float64, 0)
for _, v := range vectors {
vectors64 = append(vectors64, float64(v))
Expand All @@ -130,6 +141,7 @@ func (p *PostgresClient) Search(ctx context.Context, query models.DocQuery, vect
var res *gorm.DB

res = p.dEntity.WithContext(ctx)
res = res.Where("namespace = ?", namespace)
if query.ParentId != 0 {
res = res.Where("parent_entry_id = ?", query.ParentId)
}
Expand Down Expand Up @@ -171,12 +183,16 @@ func (p *PostgresClient) Search(ctx context.Context, query models.DocQuery, vect
}

func (p *PostgresClient) Get(ctx context.Context, oid int64, name string, group int) (*models.Element, error) {
namespace := ctx.Value("namespace")
if namespace == nil {
namespace = defaultNamespace
}
vModel := &Index{}
var res *gorm.DB
if oid == 0 {
res = p.dEntity.WithContext(ctx).Where("name = ? AND idx_group = ?", name, group).First(vModel)
res = p.dEntity.WithContext(ctx).Where("namespace = ? AND name = ? AND idx_group = ?", namespace, name, group).First(vModel)
} else {
res = p.dEntity.WithContext(ctx).Where("name = ? AND oid = ? AND idx_group = ?", name, oid, group).First(vModel)
res = p.dEntity.WithContext(ctx).Where("namespace = ? AND name = ? AND oid = ? AND idx_group = ?", namespace, name, oid, group).First(vModel)
}
if res.Error != nil {
if res.Error == gorm.ErrRecordNotFound {
Expand Down
Loading