Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add search context in search result & remove img in purecontent #64

Merged
merged 1 commit into from
Dec 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,14 @@ var RootCmd = &cobra.Command{
}

func init() {
logger.InitLog()

RootCmd.AddCommand(apps.ServeCmd)
RootCmd.AddCommand(apps.AgentCmd)
RootCmd.PersistentFlags().StringVar(&config.FilePath, "config", path.Join(config.LocalUserPath(), config.DefaultConfigBase), "friday config file")
}

func main() {
logger.InitLog()
defer logger.Sync()
if err := RootCmd.Execute(); err != nil {
panic(err)
}
Expand Down
4 changes: 4 additions & 0 deletions pkg/dispatch/plugin/doc_process.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ func trimContent(content string) (string, error) {
return "", err
}

query.Find("body img").Each(func(i int, s *goquery.Selection) {
s.Remove()
})

query.Find("body").EachWithBreak(func(i int, selection *goquery.Selection) bool {
t := strings.TrimSpace(selection.Text())
if t != "" {
Expand Down
60 changes: 60 additions & 0 deletions pkg/dispatch/plugin/doc_process_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
/*
Copyright 2024 Friday Author.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package plugin

import "testing"

func Test_trimContent(t *testing.T) {
type args struct {
content string
}
tests := []struct {
name string
args args
want string
wantErr bool
}{
{
name: "test",
args: args{
content: ` <html>
<head><title>Example</title></head>
<body>
<p>This is a paragraph.</p>
<img src="image1.jpg" alt="Image 1">
<img src="image2.jpg" alt="Image 2">
<p>This is another paragraph.</p>
</body>
</html>`,
},
want: "This is a paragraph. This is another paragraph.",
wantErr: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got, err := trimContent(tt.args.content)
if (err != nil) != tt.wantErr {
t.Errorf("trimContent() error = %v, wantErr %v", err, tt.wantErr)
return
}
if got != tt.want {
t.Errorf("trimContent() got = %v, want %v", got, tt.want)
}
})
}
}
1 change: 1 addition & 0 deletions pkg/models/doc/document.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ type Document struct {
PureContent string `json:"pure_content,omitempty"`
TitleTokens []string `json:"title_tokens,omitempty"`
ContentTokens []string `json:"content_tokens,omitempty"`
SearchContext []string `json:"search_context,omitempty"`
Marked *bool `json:"marked,omitempty"`
Unread *bool `json:"unread,omitempty"`
CreatedAt time.Time `json:"created_at"`
Expand Down
26 changes: 25 additions & 1 deletion pkg/service/chain.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package service
import (
"context"
"fmt"
"regexp"

"go.uber.org/zap"

Expand Down Expand Up @@ -154,7 +155,30 @@ func (c *Chain) GetDocument(ctx context.Context, namespace string, entryId int64
func (c *Chain) Search(ctx context.Context, filter *doc.DocumentFilter) ([]*doc.Document, error) {
ctx = c.WithNamespace(ctx, filter.Namespace)
c.Log.Debugf("search document: %+v", filter.String())
return c.DocClient.FilterDocuments(ctx, filter)
docs, err := c.DocClient.FilterDocuments(ctx, filter)
if err != nil {
c.Log.Errorf("search document error: %s", err)
return nil, err
}
for _, d := range docs {
c.GenContext(filter.Search, d)
}
return docs, nil
}

func (c *Chain) GenContext(search string, document *doc.Document) {
pattern := fmt.Sprintf(`(.{0,100})(%s)(.{0,100})`, regexp.QuoteMeta(search))
re := regexp.MustCompile(pattern)

matches := re.FindAllStringSubmatch(document.PureContent, -1)
if len(matches) > 0 {
for _, match := range matches {
before := match[1]
matchStr := match[2]
after := match[3]
document.SearchContext = append(document.SearchContext, fmt.Sprintf("...%s<b>%s</b>%s...", before, matchStr, after))
}
}
}

func (c *Chain) Delete(ctx context.Context, namespace string, entryId int64) error {
Expand Down
30 changes: 30 additions & 0 deletions pkg/service/chain_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package service_test

import (
"context"
"strings"
"time"

. "github.com/onsi/ginkgo/v2"
Expand Down Expand Up @@ -156,3 +157,32 @@ var _ = Describe("Chain", func() {
})
})
})

var _ = Describe("Search Context", func() {
var (
Chain *service.Chain
)
BeforeEach(func() {
service.ChainPool = dispatch.NewPool(10)
logger.InitLog()
Chain = &service.Chain{
Log: logger.NewLog("test"),
}
})

Describe("GenContext", func() {
Context("GenContext", func() {
It("GenContext should be successful", func() {
document := &doc.Document{
EntryId: 1,
PureContent: strings.Repeat("friday", 100) + "nanafs" + strings.Repeat("basenana", 100) + "nanafs" + strings.Repeat("friday", 100),
}
Chain.GenContext("nanafs", document)
Expect(document.SearchContext).Should(Equal([]string{
"...iday" + strings.Repeat("friday", 16) + "<b>nanafs</b>" + strings.Repeat("basenana", 12) + "base...",
"...nana" + strings.Repeat("basenana", 12) + "<b>nanafs</b>" + strings.Repeat("friday", 16) + "frid...",
}))
})
})
})
})
4 changes: 4 additions & 0 deletions pkg/store/db/model.go
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,9 @@ func (d *Document) UpdateFrom(document *doc.Document) *Document {
if document.ParentEntryID != nil {
d.ParentEntryID = document.ParentEntryID
}
if document.PureContent != "" {
d.PureContent = document.PureContent
}
return d
}

Expand All @@ -220,6 +223,7 @@ func (d *Document) To() *doc.Document {
Summary: d.Summary,
SubContent: d.SubContent,
HeaderImage: d.HeaderImage,
PureContent: d.PureContent,
Marked: &d.Marked,
Unread: &d.Unread,
CreatedAt: d.CreatedAt,
Expand Down
3 changes: 2 additions & 1 deletion pkg/store/postgres/postgres.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
package postgres

import (
"fmt"
"time"

"go.uber.org/zap"
Expand All @@ -39,7 +40,7 @@ func NewPostgresClient(postgresUrl string) (*PostgresClient, error) {
log := logger.NewLog("postgres")
dbObj, err := gorm.Open(postgres.Open(postgresUrl), &gorm.Config{Logger: utils.NewDbLogger()})
if err != nil {
panic(err)
return nil, fmt.Errorf("failed to connect to postgres: %w", err)
}

dbConn, err := dbObj.DB()
Expand Down
Loading