Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to the
mambular/arch_utils
module, including the addition of new classes, refactoring of existing code, and renaming of files. The most important changes include the introduction of theBlockDiagonal
andNeuralEmbeddingTree
classes, updates to theEmbeddingLayer
class, and substantial modifications to themLSTMblock
andsLSTMblock
classes.New Classes
BlockDiagonal
class inmambular/arch_utils/layer_utils/block_diagonal.py
for creating block-diagonal linear layers.NeuralEmbeddingTree
class inmambular/arch_utils/layer_utils/embedding_tree.py
for implementing neural decision trees with hard decision boundaries.Updates to Existing Classes
EmbeddingLayer
class to support a new embedding layer type "ndt" and integratedNeuralEmbeddingTree
for numerical embeddings. [1] [2] [3]Refactoring and File Renaming
mambular/arch_utils/embedding_layer.py
tomambular/arch_utils/layer_utils/embedding_layer.py
and updated imports accordingly.layer_utils
. [1] [2] [3]Modifications to LSTM Blocks
mLSTMblock
andsLSTMblock
classes inmambular/arch_utils/lstm_utils.py
with detailed initialization and forward pass implementations. These blocks include convolutions, gated mechanisms, and projection layers.Minor Code Cleanups
mambular/arch_utils/mamba_utils/mamba_arch.py
to improve code readability. [1] [2] [3]