-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: menu #106
enhance: menu #106
Conversation
Generally I like the changes, I'm just concerned about screen space because this menu isn't drawn outside of the window. So the options should all be useful but kept to a minimum (until we have a truly native floating menu, with submenus, etc)
|
The Wikipedia option gives more results than with the Wiki panel. But yeah, it's a bit redundant. |
When there is no results, I've added a message indicating so and links to search with Wikipedia or a search engine.
I've regrouped them in a submenu
The right click wasn't registered to hide the menu. |
If not, they will be reselected when they are immediately re-added.
@basharovV you should use the |
Thanks for another great PR. Good use of types 👍 I like the submenu, maybe it should appear on hover instead of on click though, like system menus. But that can be handled separately, I'll merge this with squash now |
This PR homogenizes the different menus:
Origin country
on albumFor the use of the artist's name/song's title, I changed the menu's labels to make them more readable.
It's a bit repetitive but it's clearer what's it will do.
Not sure if it's good. Tell me what's you think.