improve: cover (ui)

[daiyam]

This PR does:

• in the album details:
  • hide the default context menu on the cover
• in the album context menu:
  • fix the Search for artwork for the album and not the song
• in the info popup:
  • add a Search for artwork button
  • improve status text (In medadata, cover.jpg)
  • allow to delete the cover.jpg file
  • remember the directory of the last selected cover.jpg file
  • the search button get their icons replace with the loading one when searching
  • can't search artwork when there is a artwork in the metadata or it haven't been saved
  • filter possible files to .jpg or .png

[daiyam]

I wanted to talk about the support for .webp file but lofty only support png, jpg, tiff, bmp and gif (https://github.com/Serial-ATA/lofty-rs/blob/main/lofty/src/picture.rs)

.webp is natively supported by (https://community.mp3tag.de/t/support-for-webp-image-previews/51592):

• mp3tag
• foobar2000

Maybe we could support it and do a conversion to jpg since .webp is becoming common.

[basharovV]

allow to delete the cover.jpg file

Since it's not explicit that seems a bit ambiguous. The button still says "Overwrite file" when you're actually
deleting/replacing the cover in the folder. Also, you should use invoke("delete_files") which will move to trash / recycle bin instead of actually deleting the file.

[basharovV]

getElementsByClassName returns an array, so you need to call focus on the first element

[daiyam]

I'm removing the line, I think it's a debug line, a bad one at that...

[basharovV]

I noticed this will always fetch the artwork for the previously $rightClickedAlbum even when on another track. It's probably not set to null properly

[daiyam]

I can't reproduce the issue. On which view are you?

[basharovV]

To reproduce: 1) open info for any album, then 2) open info for single track in library without cover and click Fetch art. It will fetch the artwork for the previously viewed album instead of the current track.

[basharovV]

But let's fix that separately from this PR

[daiyam]

It's fixed. I'm passing all the arguments when a call to the popup occurs.

[daiyam]

Since it's not explicit that seems a bit ambiguous. The button still says "Overwrite file" when you're actually deleting/replacing the cover in the folder.

I haven't changed the behavior. It replaces the artwork in the metadata.
I just made sure that the artwork file is removed since it would take priority on the metadata one.

Also, you should use invoke("delete_files") which will move to trash / recycle bin instead of actually deleting the file.

Fixed. Thx

[basharovV]

I haven't changed the behavior. It replaces the artwork in the metadata.

Ah sorry I didn't get it at first.

I just made sure that the artwork file is removed since it would take priority on the metadata one.

In the unlikely case that you want some tracks in a folder with encoded art, while others use cover.jpg/png - removing the file will stop showing the artwork for those tracks. I'd avoid deleting it unless you're actually editing the entire album. The encoded artwork will anyway take priority.

[daiyam]

In the unlikely case that you want some tracks in a folder with encoded art, while others use cover.jpg/png - removing the file will stop showing the artwork for those tracks. I'd avoid deleting it unless you're actually editing the entire album. The encoded artwork will anyway take priority.

Now, it deletes the artwork file only when an album (with all tracks) is being edited.