Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install a specific branch or tag with @ syntax #27

Merged
merged 1 commit into from
Aug 17, 2017

Conversation

YarekTyshchenko
Copy link
Contributor

@YarekTyshchenko YarekTyshchenko commented Mar 27, 2017

Modify install command to take package@ref style syntax. This should
be idiomatic for everyone.

The ref selection is permanent, theres no way to switch the package
to a different ref without re-installing it.

@YarekTyshchenko YarekTyshchenko force-pushed the branch-selector branch 2 times, most recently from 38918b9 to 5a5e575 Compare March 27, 2017 11:02
@YarekTyshchenko
Copy link
Contributor Author

YarekTyshchenko commented Mar 27, 2017

I think basher outdated will break if remote is older than local master, but basher upgrade will fail anyway 😉 git pull wont know how to handle that!

@juanibiapina
Copy link
Member

This is great! I'll take a better look this week, but it seems exactly what I had in mind.

@juanibiapina
Copy link
Member

For me running basher outdated after installing bripkens/dock@v1.2.0 still gives an error. There should be a test for this case.

@YarekTyshchenko
Copy link
Contributor Author

You are right. Let me see if I can clean that up

@YarekTyshchenko YarekTyshchenko force-pushed the branch-selector branch 2 times, most recently from 457892d to e7a7c19 Compare March 29, 2017 00:33
- Use idiomatic `username/package@ref` style syntax.
- Check for upstream changes in a more portable way
- Disable outdated check on packages cloned by ref or tag

The ref selection is permanent at install time. Theres no way to
switch the package to a different ref without re-installing it.

Tags in git are effectively non-updatable. If you checked out a package
on a tag or commit hash its very likely that you'll never expect that
tag to change and want to pin the package to that specific version

Thanks to osse from #git for quick help ❤️
@juanibiapina juanibiapina merged commit e683443 into basherpm:master Aug 17, 2017
@juanibiapina
Copy link
Member

This is really great. Thanks and sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants