Node-package integration to build debs and rpms #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Through the effort to make smaller package, several changes to the code and dependent modules were done: - dependent modules updated; lager, mochiweb and getopt - some dependent modules removed; erlcql, velvet, casbench - deprecate R15 Andalso, there are some kludge to enable package install with node_package; - not using escriptize but just a proxy script installed - unnecessary directories like log, data created - unnecessary user and group named basho-bench created for this - not pinning dependent module versions yet
kuenishi
changed the title
|
I'll add R scripts and goodies for graphing like priv/gp_latencies.sh after this merged. |
|
Kota, can you fix up the 02da072 to avoid touching the Cassandra drivers? |
|
@slfritchie Some dependent modules of Cassandra drivers (lz4) screwed up packaging, but I can do that. I just doubted that we really need Cassandra driver or not. |
|
I'll try it later! |
lz4 and snappy does not have any tags, and that had confused `git describe`. This version still have following problems: - Current directory set to /var/lib/basho_bench When dpkg-installed basho_bench try tor start, its current directory is set as somewhere like /var/lib/basho_bench/lib/basho_bench-*. That is where the basho_bench script runs `cd` inside, because just to load correct beam files to run whole basho_bench. The workaround is to just specify `-d` option with absolute path. - Currently basho_bench has limited number of example configs installed in /etc/basho_bench. It should be installed in other place like `/usr/share/basho_bench/examples` but node_package seems not supporting such installation other than manpages.
|
From my commit log: lz4 and snappy does not have any tags, and that had confused
|
|
Here, it's ready for review again. Just a kind reminder. |
|
Hi, sorry about the delay, Kota. Is the addition of the |
|
+1 to everything else. |
kuenishi
added a commit
that referenced
this pull request
Nov 10, 2014
Node-package integration to build debs and rpms
|
Thank you for review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node package requires the latest version tagged on github, so I'd like to tag this as 0.10.0 once this is merged. The number comes from latest version number in
basho_bench.app.src.