-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moved in bitcask schema bits from riak.schema #112
Conversation
Just as a general note ... there are several apps using Bitcask besides Riak. |
I asked Joe about this in the core/kv channel earlier today, he said that |
I reviewed the Wasn't one of the initial reasons for keeping this in *this suggestion may be prone to tired crazy talk |
@jrwest you crazy! But seriously folks, I am confident that this is the way to go. I only wish that rebar had a "test" scope for dependencies. Other than running the unit tests for the schema, this will have no effect on non-cuttlefish compatible projects. There will be stuff that remains in the riak and riak-ee repositories, but the less that does, the less duplication we'll have to deal with. |
For the record, @jrwest and I had a mumble and he's cool with this now :) |
]}. | ||
|
||
|
||
%% @doc Require the CRC to be present at the end of hintfiles. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment should be updated, since you've (rightly) changed the default to true. That also reminds me I need to fix this so it actually works for 2.0 (see issue #101).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushed new wording, let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/them/CRC signatures/ and merge it
Other than the one comment, unit tests pass and values have been transcribed accurately, it looks like. Once the comment is addressed, I think that this can be merged, although like all of the schema changes, it deserves some more strenuous testing when fully integrated. 👍 |
moved in bitcask schema bits from riak.schema
needs cuttlefish from branch jd-test-tools
see: basho/cuttlefish#44