Rename/refactor a bunch of cuttlefish settings. #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… docs. * Setting name is removed from all docstrings. The name can be generated from the schema and will be displayed when using the "describe" cuttlefish command. * sync_strategy -> sync.strategy; sync_interval -> sync.interval * merge_window -> merge.policy -- There is no window if set to 'always' or 'never', so "policy" seems a better name. * merge_window.start/end -> merge.window.start/end * frag_merge_trigger -> merge.triggers.fragmentation (more descriptive). The "is_percentage" validator was also added to constrain the values. * dead_bytes_merge_trigger -> merge.triggers.dead_bytes (similar to frag_merge_trigger). * frag_threshold -> thresholds.fragmentation (again adding "is_percentage" validator) * dead_bytes_threshold -> thresholds.dead_bytes * small_file_threshold -> thresholds.small_file * max_fold_age -> fold.max_age. Added the possible value of `unlimited` (replaces -1 magic value) as well as a duration in milliseconds. The input value is upscaled to microseconds, but we have no evidence of anyone setting this setting. Probably best to change it in advanced.config. * max_fold_puts -> fold.max_puts. Added value of `unlimited` which replaces the magic value of -1. * Added `off` to expiry, which disables the feature (instead of the -1 magic value). * require_hint_crc -> hintfile_checksums. Changed settings to `strict` and `allow_missing` instead of true/false. * expiry_grace_time -> expiry.grace_time * multi_backend settings were converted to use @see tags instead of copying the docstrings.
|
Hi, all. Sorry I overlooked this PR during this week's merge madness. Looks nice, and doesn't appear to upset any existing riak_test scripts, as far as I can tell from today's 'master' r_t repo. +1, I'll merge it, thanks! |
slfritchie
added a commit
that referenced
this pull request
Dec 26, 2013
Rename/refactor a bunch of cuttlefish settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improved the docs and employed the @see option for multi_backend settings. For details about the changes, see f1dcf6e.