Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bitcask_pulse model to know when a keydir may have been frozen. #181

Open
wants to merge 2 commits into
base: develop-3.0
Choose a base branch
from
Open

Fix bitcask_pulse model to know when a keydir may have been frozen. #181

wants to merge 2 commits into from

Commits on Jul 16, 2014

  1. Fix bitcask_pulse model to know when a keydir may have been frozen. 

    * Rename `bitcask_nifs:keydir_remove/3` -> * `bitcask_nifs:keydir_remove_int/3`

* Use a compile-time -ifdef magic to add `pulse_log_call()` wrappers
around all keydir NIF calls that can mutate the keydir.

* Make several changes to the bitcask_pulse model:

    * Filter out bad reads from either kind of bad folds
    * If a bad read happens, that's bad
    * If a bad fold happens, then figure out during what period of
      at-last-one-folder-is-running-time that the bad result appeared.
      Then figure out if a keydir mutating NIF was called; if yes,
      then it's possible that the keydir was frozen ... we don't know
      for sure, but we won't cause the model to fail in this case.
    @slfritchie
    slfritchie committed Jul 16, 2014
    Configuration menu
    Copy the full SHA
    a384cb9 View commit details
    Browse the repository at this point in the history

  2. Fix up this branch's PULSE model with a couple more things 

    1. Use `keydir_call` and `keydir_return` for the trace labels
for NIF mutations.

2. Only consider *successful* mutations when checking for keydir frozenness.
    @slfritchie
    slfritchie committed Jul 16, 2014
    Configuration menu
    Copy the full SHA
    9aaa165 View commit details
    Browse the repository at this point in the history